Add an env var to set the init locale code on startup #10081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
force-pushed
the
i18n/allow-env-var-default-locale
branch
from
c103a93
to
e939a2a
Compare
Codecov Report
@@ Coverage Diff @@
## features/i18n #10081 +/- ##
=================================================
+ Coverage 59.18% 59.24% +0.05%
=================================================
Files 180 180
Lines 5574 5582 +8
Branches 1050 1052 +2
=================================================
+ Hits 3299 3307 +8
Misses 1812 1812
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petersg83
suggested changes
Apr 20, 2021
|
|
||
| if (!matchingLocale) { | ||
| throw new Error( | ||
| 'Unknown locale code provided in the envrionment variable STRAPI_PLUGIN_I18N_INIT_LOCALE_CODE' |
Convly
reviewed
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add an env var to set the init locale code on startup