Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some i18n e2e tests #10256

Closed
wants to merge 2 commits into from
Closed

Add some i18n e2e tests #10256

wants to merge 2 commits into from

Conversation

petersg83
Copy link
Contributor

Merge #10255 before.

  • Add many e2e tests
  • Make a small fix. With the Content-Manager API It was possible to create a related entry in the default locale even if the default locale was already existing. To do it, it was need to not specify the locale in the query.

@petersg83 petersg83 added issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:i18n Source is plugin/i18n package labels May 6, 2021
@petersg83 petersg83 added this to the 3.6.2 milestone May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #10256 (1ab07ef) into master (311d8e1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10256   +/-   ##
=======================================
  Coverage   57.86%   57.86%           
=======================================
  Files         183      183           
  Lines        6348     6348           
  Branches     1392     1392           
=======================================
  Hits         3673     3673           
  Misses       2215     2215           
  Partials      460      460           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 57.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311d8e1...1ab07ef. Read the comment docs.

@alexandrebodin alexandrebodin removed this from the 3.6.2 milestone May 11, 2021
@petersg83 petersg83 changed the base branch from master to 1.6.4 May 25, 2021 10:00
@petersg83 petersg83 changed the base branch from 1.6.4 to master May 25, 2021 10:00
@petersg83 petersg83 changed the base branch from master to releases/v4 May 25, 2021 10:05
@petersg83 petersg83 changed the base branch from releases/v4 to master May 25, 2021 10:06
@petersg83
Copy link
Contributor Author

There is an issue with the tests that is difficult to fix in V3. As the code won't change before the V4. We won't add those tests, knowing that they passed.
The detected issue is fixed there : #10378

@petersg83 petersg83 closed this May 25, 2021
@petersg83 petersg83 deleted the i18n/add-tests branch May 25, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:i18n Source is plugin/i18n package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants