New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RBAC permissions without subject ignoring conditions #10291
Fix RBAC permissions without subject ignoring conditions #10291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10291 +/- ##
==========================================
+ Coverage 57.82% 57.84% +0.01%
==========================================
Files 184 184
Lines 6393 6395 +2
Branches 1395 1396 +1
==========================================
+ Hits 3697 3699 +2
Misses 2233 2233
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works perfect in testing.
08b9bef
to
bfe580b
Compare
bfe580b
to
7fe9797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does it do?
Fix a bug that causes the RBAC permissions that don't have any subject (for example
plugins::upload.read
) to ignore the attributed conditions.Why is it needed?
Breaking RBAC (media library & other plugins)
How to test it?
Related issue(s)/PR(s)
fix #10221