Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10328 #10339

Merged
merged 1 commit into from May 19, 2021
Merged

Fixes #10328 #10339

merged 1 commit into from May 19, 2021

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

What does it do?

It fixes #10328

@soupette
Fixes #10328
bdfd531 
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette requested a review from HichamELBSI May 18, 2021 08:01
@codecov
Copy link

codecov bot commented May 18, 2021 •
edited

Codecov Report

Merging #10339 (bdfd531) into master (4c844a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10339   +/-   ##
=======================================
  Coverage   57.84%   57.84%           
=======================================
  Files         184      184           
  Lines        6395     6395           
  Branches     1396     1396           
=======================================
  Hits         3699     3699           
  Misses       2233     2233           
  Partials      463      463
Flag Coverage Δ
front ∅ <ø> (∅)
unit 57.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c844a7...bdfd531. Read the comment docs.

@derrickmehaffy derrickmehaffy self-requested a review May 18, 2021 18:10
derrickmehaffy
derrickmehaffy approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on reproduction repo with this fix and it worked perfect. Thanks!

@derrickmehaffy derrickmehaffy mentioned this pull request May 18, 2021
Closed
@derrickmehaffy derrickmehaffy added the issue: bug Issue reporting a bug label May 18, 2021
@derrickmehaffy derrickmehaffy added this to the 3.6.3 milestone May 18, 2021
@sam-pires
Copy link
Contributor

sam-pires commented May 19, 2021 •
edited

Thanks for testing @derrickmehaffy 👍

LGTM, good to merge on my side @soupette

@soupette soupette merged commit 04ad9bd into master May 19, 2021
@soupette soupette deleted the fix/10328 branch May 19, 2021 13:36
@alexandrebodin alexandrebodin added the source: plugin:i18n Source is plugin/i18n package label Jun 2, 2021
This was referenced Jun 2, 2021
Open
Open
Merged
Merged
Open
Open
This was referenced Jun 13, 2021
Merged
Open
@renovate renovate bot mentioned this pull request Jun 20, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 30, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Aug 11, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickmehaffy derrickmehaffy derrickmehaffy approved these changes

@sam-pires sam-pires sam-pires approved these changes

@HichamELBSI HichamELBSI Awaiting requested review from HichamELBSI

Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: plugin:i18n Source is plugin/i18n package
Projects
None yet
Milestone
3.6.3
Development

Successfully merging this pull request may close these issues.

'Fill in from another locale' only shows the initial default locale
4 participants
@soupette @sam-pires @derrickmehaffy @alexandrebodin