Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #8020: Disabled autoPopulate for File model (upload plugin) #10370

Merged
merged 4 commits into from Jun 2, 2021
Merged

Issue #8020: Disabled autoPopulate for File model (upload plugin) #10370

merged 4 commits into from Jun 2, 2021

Conversation

andriichern
Copy link
Contributor

What does it do?

Added autoPopulate: false option for File model description

Why is it needed?

Fixes #8020 issue

@strapi-cla
Copy link

strapi-cla commented May 24, 2021

CLA assistant check
All committers have signed the CLA.

@derrickmehaffy derrickmehaffy added flag: don't merge This PR should not be merged at the moment flag: 💥 Breaking change This PR contains breaking changes and should not be merged labels May 24, 2021
@alexandrebodin alexandrebodin removed flag: don't merge This PR should not be merged at the moment flag: 💥 Breaking change This PR contains breaking changes and should not be merged labels May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #10370 (9e835a3) into master (6b8aedf) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10370   +/-   ##
=======================================
  Coverage   57.84%   57.84%           
=======================================
  Files         184      184           
  Lines        6395     6395           
  Branches     1394     1394           
=======================================
  Hits         3699     3699           
  Misses       2233     2233           
  Partials      463      463           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 57.84% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-upload/services/Upload.js 14.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8aedf...9e835a3. Read the comment docs.

@alexandrebodin alexandrebodin added this to the 3.6.3 milestone May 26, 2021
@alexandrebodin alexandrebodin added source: core:upload Source is core/upload package issue: enhancement Issue suggesting an enhancement to an existing feature labels May 26, 2021
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strapi media library very slow or even fails to load when files are linked to multiple entities
4 participants