Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left menu header background color link from theme #10584

Merged
merged 3 commits into from Aug 4, 2021
Merged

left menu header background color link from theme #10584

merged 3 commits into from Aug 4, 2021

Conversation

omrirz
Copy link
Contributor

@omrirz omrirz commented Jul 5, 2021

What does it do?

Read the leftMenu header link background from theme.

Why is it needed?

So it can be overridden by a user in a consistent way.

@strapi-cla
Copy link

strapi-cla commented Jul 5, 2021

CLA assistant check
All committers have signed the CLA.

@derrickmehaffy
Copy link
Member

@omrirz we are planning a full sweep of changes in our v4 that will give very simple override options to the color theming so it's not likely we will merge this for the v3 since the v4 is due for a stable release in Sept.

We are completely rebuilding the entire design system and getting rid of the Buffet.js one.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants