Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one-click deploy buttons #10592

Merged
merged 2 commits into from Aug 4, 2021
Merged

Conversation

pierreburgy
Copy link
Member

What does it do?

Remove the one-click buttons as it is now the installation workflow we recommend.

Why is it needed?

Strapi has been designed to be installed in a local environment, versioned through git, and deployed to production. The one-click deploy buttons create some confusion.

How to test it?

Preview the markdown.md file.

Related issue(s)/PR(s)

None.

@strapi-cla
Copy link

strapi-cla commented Jul 8, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #10592 (e74b93a) into master (df832fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10592   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         185      185           
  Lines        6431     6431           
  Branches     1400     1400           
=======================================
  Hits         3731     3731           
  Misses       2236     2236           
  Partials      464      464           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 58.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df832fa...e74b93a. Read the comment docs.

derrickmehaffy
derrickmehaffy previously approved these changes Jul 8, 2021
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrickmehaffy
Copy link
Member

@pierreburgy can you sign the CLA 🤣

Pierre Burgy added 2 commits July 19, 2021 16:00
Signed-off-by: Pierre Burgy <pierre.burgy@gmail.com>
Signed-off-by: Pierre Burgy <pierre.burgy@gmail.com>
@pierreburgy pierreburgy force-pushed the remove-one-click-deploy-buttons branch from 1b27968 to e74b93a Compare July 19, 2021 14:00
@alexandrebodin alexandrebodin added this to the 3.6.6 milestone Aug 4, 2021
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants