-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an event to CTB banner button #10687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10687 +/- ##
=======================================
Coverage 58.01% 58.01%
=======================================
Files 185 185
Lines 6431 6431
Branches 1398 1398
=======================================
Hits 3731 3731
Misses 2236 2236
Partials 464 464
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is the yarn lock bump wanted?
@mfrachet I think yes, the buffet version has been updated. |
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
54dede4
to
bdfd1c6
Compare
Signed-off-by: HichamELBSI elabbassih@gmail.com
What does it do?
Add a tracker event in the CTB list view banner button
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request