Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an event to CTB banner button #10687

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Conversation

HichamELBSI
Copy link
Contributor

Signed-off-by: HichamELBSI elabbassih@gmail.com

What does it do?

Add a tracker event in the CTB list view banner button

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #10687 (455b4e0) into master (c373c3d) will not change coverage.
The diff coverage is n/a.

❗ Current head 455b4e0 differs from pull request most recent head bdfd1c6. Consider uploading reports for the commit bdfd1c6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10687   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         185      185           
  Lines        6431     6431           
  Branches     1398     1398           
=======================================
  Hits         3731     3731           
  Misses       2236     2236           
  Partials      464      464           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 58.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c373c3d...bdfd1c6. Read the comment docs.

mfrachet
mfrachet previously approved these changes Aug 4, 2021
Copy link
Contributor

@mfrachet mfrachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the yarn lock bump wanted?

@HichamELBSI
Copy link
Contributor Author

LGTM. Is the yarn lock bump wanted?

@mfrachet I think yes, the buffet version has been updated.

Signed-off-by: HichamELBSI <elabbassih@gmail.com>
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
@alexandrebodin alexandrebodin added this to the 3.6.6 milestone Aug 4, 2021
@alexandrebodin alexandrebodin added the source: core:admin Source is core/admin package label Aug 4, 2021
@alexandrebodin alexandrebodin removed this from the 3.6.6 milestone Aug 4, 2021
@alexandrebodin alexandrebodin removed the source: core:admin Source is core/admin package label Aug 4, 2021
@alexandrebodin alexandrebodin modified the milestone: 3.6.6 Aug 4, 2021
@alexandrebodin alexandrebodin merged commit ae6aa27 into master Aug 4, 2021
@alexandrebodin alexandrebodin deleted the ctb/add-field-event branch August 4, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants