Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disable graphql playground in staging environment as well #10756

Conversation

kevinadhiguna
Copy link

What does it do?

Disable GraphQL playground in staging environment as well (other than production environment).

Why is it needed?

Some projects might only have/run on :

  1. Development, Staging, Production environments
  2. Development and Staging environments only

How to test it?

In environment variable (.env file), set NODE_ENV value to staging or production to see the GraphQL playground disabled.

Any suggestion is appreciated!

@strapi-cla
Copy link

strapi-cla commented Aug 19, 2021

CLA assistant check
All committers have signed the CLA.

@derrickmehaffy
Copy link
Member

Hello,

We are currently in a community PR change freeze and at this time we are only considering critical fixes from external contributors until after our v4 launch. If you believe this was closed in error, please email us at community@strapi.io.

Thanks!

@kevinadhiguna
Copy link
Author

My bad, thanks for the info. May I submit the same PR after Strapi v4 is launched ?

@derrickmehaffy
Copy link
Member

My bad, thanks for the info. May I submit the same PR after Strapi v4 is launched ?

Sure, although I'd like a little more discussion about this as many of our users intend to have this in Staging but not in production. Functionally I think we should modify the GraphQL settings to allow users to choose in what environments they do or don't want it enabled and just not blindly disabling it in staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants