Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugins views #10764

Merged
merged 6 commits into from Aug 23, 2021
Merged

Remove plugins views #10764

merged 6 commits into from Aug 23, 2021

Conversation

soupette
Copy link
Contributor

What does it do?

This PR removes the plugin from the admin in order to be able to migrate the views more easily.
It also fixes and commented some tests.

Signed-off-by: soupette <cyril@strapi.io>
Signed-off-by: soupette <cyril@strapi.io>
Signed-off-by: soupette <cyril@strapi.io>
Signed-off-by: soupette <cyril@strapi.io>
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #10764 (3e8a7dc) into v4/ds-migration (9e887a2) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e8a7dc differs from pull request most recent head 4b6341a. Consider uploading reports for the commit 4b6341a to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           v4/ds-migration   #10764   +/-   ##
================================================
  Coverage            57.73%   57.73%           
================================================
  Files                  183      183           
  Lines                 6466     6466           
  Branches              1343     1343           
================================================
  Hits                  3733     3733           
  Misses                2263     2263           
  Partials               470      470           
Flag Coverage Δ
front ∅ <ø> (?)
unit 57.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8aaa9...4b6341a. Read the comment docs.

Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette merged commit d557499 into v4/ds-migration Aug 23, 2021
@soupette soupette deleted the chore/remove-plugins branch August 23, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants