Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration/admin setting edit role #10770

Merged
merged 9 commits into from
Aug 30, 2021

Conversation

smontlouis
Copy link
Contributor

@smontlouis smontlouis commented Aug 20, 2021

What does it do?

Move a part of Settings - Admin Panel Roles - Edit a role to DS.

This is only a portion of the whole page.

  • Custom select is settings modal is not done yet.

How to test it?

Go to /admin/settings/roles

Screenshots

image
image
image
image
image

@strapi-cla
Copy link

strapi-cla commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

@smontlouis smontlouis force-pushed the migration/admin-setting-edit-role branch from 368f887 to a640881 Compare August 30, 2021 07:14
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #10770 (6eae963) into v4/ds-migration (701303e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           v4/ds-migration   #10770   +/-   ##
================================================
  Coverage            57.97%   57.97%           
================================================
  Files                  188      188           
  Lines                 6504     6504           
  Branches              1351     1351           
================================================
  Hits                  3771     3771           
  Misses                2262     2262           
  Partials               471      471           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 57.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd3f54...6eae963. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you just clean the unused files so we can we merge this one?

Good job!

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette merged commit 6f7ad2b into v4/ds-migration Aug 30, 2021
@soupette soupette deleted the migration/admin-setting-edit-role branch August 30, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants