-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration/admin setting edit role #10770
Conversation
368f887
to
a640881
Compare
Codecov Report
@@ Coverage Diff @@
## v4/ds-migration #10770 +/- ##
================================================
Coverage 57.97% 57.97%
================================================
Files 188 188
Lines 6504 6504
Branches 1351 1351
================================================
Hits 3771 3771
Misses 2262 2262
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you just clean the unused files so we can we merge this one?
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does it do?
Move a part of Settings - Admin Panel Roles - Edit a role to DS.
This is only a portion of the whole page.
How to test it?
Go to
/admin/settings/roles
Screenshots