Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sharp to 0.29.0 #10800

Merged
merged 1 commit into from Sep 1, 2021
Merged

bump sharp to 0.29.0 #10800

merged 1 commit into from Sep 1, 2021

Conversation

tlux
Copy link
Contributor

@tlux tlux commented Aug 25, 2021

What does it do?

Upgrades sharp dependency in strapi-plugin-upload to latest stable version (0.29.0).

Why is it needed?

In some cases, width and height could not be determined for PNG images as sharp threw an error (Input buffer has corrupt header: pngload_buffer: invalid chunk position). This also prevented strapi-plugin-upload from generating different image sizes/formats.

The latest sharp version no longer has this issue.

How to test it?

--

Related issue(s)/PR(s)

--

@strapi-cla
Copy link

strapi-cla commented Aug 25, 2021

CLA assistant check
All committers have signed the CLA.

@derrickmehaffy
Copy link
Member

Changelog for Sharp here: https://sharp.pixelplumbing.com/changelog#v0290---17th-august-2021

v0.29.0 - 17th August 2021
Drop support for Node.js 10, now requires Node.js >= 12.13.0.

Add background property to PNG and GIF image metadata.

Add compression property to HEIF image metadata.

AVIF encoding now defaults to 4:4:4 chroma subsampling.

Allow multiple platform-arch binaries in same node_modules installation tree.

Default to single-channel b-w space when extractChannel is used.

Allow installation directory to contain spaces (regression in v0.26.0).

Add pipelineColourspace operator to set the processing space.

Allow bit depth to be set when using raw input and output.

Allow negate to act only on non-alpha channels.


No breaking changes, although we are in a change freeze I don't see why we couldn't merge this.

@derrickmehaffy derrickmehaffy added the source: dependencies Source is dependency problem label Aug 25, 2021
@derrickmehaffy
Copy link
Member

Waiting for tests to pass before requesting review

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #10800 (d018999) into master (8972d78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10800   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         185      185           
  Lines        6429     6429           
  Branches     1395     1395           
=======================================
  Hits         3737     3737           
  Misses       2230     2230           
  Partials      462      462           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8972d78...d018999. Read the comment docs.

@alexandrebodin alexandrebodin added this to the 3.6.9 milestone Sep 1, 2021
@alexandrebodin alexandrebodin added source: core:upload Source is core/upload package issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 1, 2021
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@alexandrebodin alexandrebodin merged commit ce8ac14 into strapi:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:upload Source is core/upload package source: dependencies Source is dependency problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants