Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins page #11607

Merged
merged 1 commit into from Nov 17, 2021
Merged

Add plugins page #11607

merged 1 commit into from Nov 17, 2021

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril@strapi.io

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request
Screenshot 2021-11-17 at 15 10 11

Signed-off-by: soupette <cyril@strapi.io>
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #11607 (89ac5fe) into v4/plugins-page (add53a3) will decrease coverage by 11.89%.
The diff coverage is n/a.

❗ Current head 89ac5fe differs from pull request most recent head ed20b01. Consider uploading reports for the commit ed20b01 to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                  @@
##           v4/plugins-page   #11607       +/-   ##
====================================================
- Coverage            59.01%   47.12%   -11.90%     
====================================================
  Files                  174      212       +38     
  Lines                 6032     8117     +2085     
  Branches              1267     1775      +508     
====================================================
+ Hits                  3560     3825      +265     
- Misses                2047     3525     +1478     
- Partials               425      767      +342     
Flag Coverage Δ
front ?
unit 47.12% <ø> (-11.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/admin/server/controllers/admin.js 34.54% <ø> (+2.40%) ⬆️
...ackages/core/admin/server/controllers/api-token.js 100.00% <ø> (+3.57%) ⬆️
...ckages/core/admin/server/controllers/permission.js 61.11% <ø> (-3.89%) ⬇️
packages/core/admin/server/controllers/role.js 49.15% <ø> (-0.06%) ⬇️
packages/core/admin/server/controllers/user.js 70.00% <ø> (+2.72%) ⬆️
packages/core/admin/server/services/action.js 92.85% <ø> (+0.54%) ⬆️
packages/core/admin/server/services/auth.js 93.93% <ø> (+0.18%) ⬆️
...r/services/permission/permissions-manager/index.js 100.00% <ø> (+2.63%) ⬆️
...ervices/permission/permissions-manager/sanitize.js 86.66% <ø> (ø)
packages/core/admin/server/services/role.js 96.66% <ø> (+0.64%) ⬆️
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5767590...ed20b01. Read the comment docs.

@soupette soupette merged commit db1774b into v4/plugins-page Nov 17, 2021
@soupette soupette deleted the v4/plugins-page-front branch November 17, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants