Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V4] fix wysiwyg hint #11620

Merged
merged 2 commits into from Nov 18, 2021
Merged

[V4] fix wysiwyg hint #11620

merged 2 commits into from Nov 18, 2021

Conversation

vincentbpro
Copy link
Contributor

What does it do?

Adds a missing hint on the WYSIWYG component, it reuses the same hint component used for the inputJSON field.

Why is it needed?

Fields are expected to show their description below in the hint component

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #11620 (fa482ee) into releases/v4 (710e2a7) will increase coverage by 47.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           releases/v4   #11620       +/-   ##
================================================
+ Coverage             0   47.12%   +47.12%     
================================================
  Files                0      212      +212     
  Lines                0     8117     +8117     
  Branches             0     1775     +1775     
================================================
+ Hits                 0     3825     +3825     
- Misses               0     3525     +3525     
- Partials             0      767      +767     
Flag Coverage Δ
unit 47.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/core/admin/server/services/content-type.js 95.77% <100.00%> (ø)
packages/plugins/i18n/server/services/metrics.js 100.00% <0.00%> (ø)
...ckages/plugins/i18n/server/services/iso-locales.js 100.00% <0.00%> (ø)
packages/core/database/lib/fields.js 10.20% <0.00%> (ø)
test/helpers/create-context.js 100.00% <0.00%> (ø)
packages/core/utils/lib/set-creator-fields.js 100.00% <0.00%> (ø)
packages/core/strapi/lib/services/metrics/index.js 59.18% <0.00%> (ø)
...ages/core/strapi/lib/commands/generate-template.js 94.87% <0.00%> (ø)
...ages/plugins/i18n/server/services/content-types.js 88.88% <0.00%> (ø)
.../plugins/i18n/server/content-types/locale/index.js 100.00% <0.00%> (ø)
... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6dc5a...fa482ee. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette merged commit 96f9156 into releases/v4 Nov 18, 2021
@soupette soupette deleted the v4/fix-wysiwyg-hint branch November 18, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants