[V4] Prebuild the admin panel. #11622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: soupette <cyril@strapi.io>
Signed-off-by: soupette <cyril@strapi.io>
Codecov Report
@@ Coverage Diff @@
## releases/v4 #11622 +/- ##
================================================
+ Coverage 0 47.12% +47.12%
================================================
Files 0 212 +212
Lines 0 8117 +8117
Branches 0 1775 +1775
================================================
+ Hits 0 3825 +3825
- Misses 0 3525 +3525
- Partials 0 767 +767
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
requested changes
Nov 18, 2021
packages/core/admin/package.json
Outdated
| @@ -9,7 +9,9 @@ | |||
| "scripts": { | |||
| "prepublishOnly": "node ./scripts/build.js", | |||
| "test": "echo \"no tests yet\"", | |||
| "develop": "cross-env NODE_ENV=development webpack serve --config webpack.config.dev.js --progress profile", | |||
| "create:plugin-file": "node ./scripts/create-dev-plugins-file.js", | |||
| "dev": "cross-env NODE_ENV=development webpack serve --config webpack.config.dev.js --progress profile", | |||
There was a problem hiding this comment.
Suggested change
| "dev": "cross-env NODE_ENV=development webpack serve --config webpack.config.dev.js --progress profile", | |
| "develop:webpack": "cross-env NODE_ENV=development webpack serve --config webpack.config.dev.js --progress profile", |
| */ | ||
| const createFile = async () => { | ||
| const customPluginFile = join(__dirname, '..', 'admin', 'src', 'plugins-dev.js'); | ||
| const pluginFileDest = resolve(__dirname, '..', 'admin', 'src', 'plugins.js'); |
There was a problem hiding this comment.
you can use join here too
| .split('/') | ||
| .slice(-1)[0]; | ||
|
|
||
| const adminEntryPoint = resolve(join(__dirname, '..', 'admin', 'src')); |
There was a problem hiding this comment.
you can use join only here
| const { camelCase } = require('lodash'); | ||
| const fs = require('fs-extra'); | ||
|
|
||
| const CORE_PLUGINS = ['content-type-builder', 'email', 'upload', 'i18n']; |
There was a problem hiding this comment.
i18n is in the plugins folder you can remove it here
packages/core/admin/scripts/build.js
Outdated
| createPluginsFile, | ||
| } = require('./create-plugins-file'); | ||
|
|
||
| const PLUGINS_TO_INSTALL = ['i18n']; |
There was a problem hiding this comment.
at the beginning of v4 we will keep users-permissions installed too so you should keep it here
Signed-off-by: soupette <cyril@strapi.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It fixes the build script, now only the plugins that are shipped with a generated app will be built.
It also introduces a script that writes the plugins.js file before starting the webpack-dev-server when developing in the monorepo.
Why is it needed?
In order to only build the necessary plugin when releasing a new version of Strapi.
How to test it?
The build script should build the admin correctly and the dev mode inside the monorepo should work as it used to.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request