Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Fix ctb navigation and upgrade DS version #11628

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril@strapi.io

What does it do?

It upgrades the DS version and also fixes the navigation when the user is doing the following:

  1. in the ctb create a DZ field
  2. Fill the name input
  3. Click on the advanced settings tab
  4. click on finish.

Signed-off-by: soupette <cyril@strapi.io>
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #11628 (443c4d0) into releases/v4 (e47b360) will not change coverage.
The diff coverage is n/a.

❗ Current head 443c4d0 differs from pull request most recent head 86e9995. Consider uploading reports for the commit 86e9995 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           releases/v4   #11628   +/-   ##
============================================
  Coverage        47.12%   47.12%           
============================================
  Files              212      212           
  Lines             8117     8117           
  Branches          1775     1775           
============================================
  Hits              3825     3825           
  Misses            3525     3525           
  Partials           767      767           
Flag Coverage Δ
unit 47.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7f02a...86e9995. Read the comment docs.

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except tests failing)

Signed-off-by: soupette <cyril@strapi.io>
@soupette soupette merged commit bf06c5f into releases/v4 Nov 18, 2021
@soupette soupette deleted the update-ds branch November 18, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants