New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 404 page and init 500 page #12236
Conversation
@@ -87,6 +88,7 @@ const Admin = () => { | |||
<InstalledPluginsPage /> | |||
</Route> | |||
<Route path="/404" component={NotFoundPage} /> | |||
<Route path="/500" component={InternalErrorPage} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ We init the 500 page although there is no redirection to /500 in the app for the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's a good idea!
I think that at some point we should improve the error handling in the admin by having two different views:
- one in production that redirects the user to the 500 page
- one in development where we implement an error boundary properly
Anyway good work!
Codecov Report
@@ Coverage Diff @@
## master #12236 +/- ##
=======================================
Coverage 47.68% 47.68%
=======================================
Files 212 212
Lines 8223 8223
Branches 1863 1863
=======================================
Hits 3921 3921
Misses 3547 3547
Partials 755 755
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
packages/core/admin/admin/src/pages/InternalErrorPage/tests/index.test.js
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/pages/NotFoundPage/tests/index.test.js
Outdated
Show resolved
Hide resolved
5300d31
to
1fdb56e
Compare
1fdb56e
to
f046265
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f046265
to
0369846
Compare
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
0369846
to
6bbdb97
Compare
All in the title