Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSO redirection #12340

Merged
merged 2 commits into from Jan 28, 2022
Merged

Fix SSO redirection #12340

merged 2 commits into from Jan 28, 2022

Conversation

Convly
Copy link
Member

@Convly Convly commented Jan 28, 2022

What does it do?

Redirect URLs for SSO were missing a default "admin" value since the route has changed for the V4.

Why is it needed?

Redirect for SSO is broken. See #12328

How to test it?

See #12328

Related issue(s)/PR(s)

fix #12328

@Convly Convly added issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package labels Jan 28, 2022
@Convly Convly added this to the 4.0.6 milestone Jan 28, 2022
@Convly Convly requested a review from soupette January 28, 2022 13:25
@Convly Convly added this to In progress in Developer Experience - Old via automation Jan 28, 2022
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #12340 (831b7eb) into master (90d3c76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12340   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files         210      210           
  Lines        8140     8140           
  Branches     1836     1836           
=======================================
  Hits         3888     3888           
  Misses       3503     3503           
  Partials      749      749           
Flag Coverage Δ
front ?
unit 47.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d3c76...831b7eb. Read the comment docs.

@Convly Convly merged commit bace0b9 into master Jan 28, 2022
Developer Experience - Old automation moved this from In progress to Fixed/Shipped Jan 28, 2022
@Convly Convly deleted the fix/sso-wrong-redirect branch January 28, 2022 14:04
@maccomaccomaccomacco maccomaccomaccomacco moved this from Fixed/Shipped to Closed in Developer Experience - Old Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

SSO + AAD yield a 404 for an error page that doesn't exist
2 participants