Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation key correction of wording #12394

Merged
merged 1 commit into from Mar 9, 2022

Conversation

yasudacloud
Copy link
Contributor

What does it do?

Fixed the translation key for the mail plugin.

Why is it needed?

I was working on a plugin that translates into Japanese, and I noticed that it didn't translate correctly.

How to test it?

Run examples/getstarted to enable the Japanese language setting.
This is because the default English and French languages do not have a translation key.

When I open the page in question, the buttons and text fields that should have translation keys are still in English.

Settings > Configuration
fix_before
fix_after

@strapi-cla
Copy link

strapi-cla commented Feb 3, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@vincentbpro vincentbpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM
Could you please sign the CLA with all the email adresses you commited with (it is blocking the merge)

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #12394 (a2dcfb7) into master (c4a6ca5) will not change coverage.
The diff coverage is n/a.

❗ Current head a2dcfb7 differs from pull request most recent head c0e555c. Consider uploading reports for the commit c0e555c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12394   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files         210      210           
  Lines        8140     8140           
  Branches     1836     1836           
=======================================
  Hits         3888     3888           
  Misses       3503     3503           
  Partials      749      749           
Flag Coverage Δ
front ?
unit 47.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a6ca5...c0e555c. Read the comment docs.

@yasudacloud
Copy link
Contributor Author

@vincentbpro

Thanks for the reply.
Regarding CLA, I have the wrong email address, what should I do?
Take down the PR once?

Sorry I'm new to this.

@vincentbpro
Copy link
Contributor

@yasudacloud No worries :)

  • You can change the commit author on your local branch (example here)
  • Then you can force push your branch to rewrite commit history and we should be good

@yasudacloud
Copy link
Contributor Author

@vincentbpro

Thanks!
I tried to fix it, but what do you think?

@vincentbpro
Copy link
Contributor

Thanks! should be good :)

@alexandrebodin alexandrebodin added pr: enhancement This PR adds or updates some part of the codebase or features and removed issue: translation labels Mar 2, 2022
@alexandrebodin alexandrebodin added this to the 4.1.4 milestone Mar 9, 2022
@alexandrebodin alexandrebodin merged commit a0fd0d1 into strapi:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:email Source is core/email package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants