New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation key correction of wording #12394
Translation key correction of wording #12394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! LGTM
Could you please sign the CLA with all the email adresses you commited with (it is blocking the merge)
Codecov Report
@@ Coverage Diff @@
## master #12394 +/- ##
=======================================
Coverage 47.76% 47.76%
=======================================
Files 210 210
Lines 8140 8140
Branches 1836 1836
=======================================
Hits 3888 3888
Misses 3503 3503
Partials 749 749
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Thanks for the reply. Sorry I'm new to this. |
@yasudacloud No worries :)
|
dd0682d
to
c0e555c
Compare
Thanks! |
Thanks! should be good :) |
What does it do?
Fixed the translation key for the mail plugin.
Why is it needed?
I was working on a plugin that translates into Japanese, and I noticed that it didn't translate correctly.
How to test it?
Run examples/getstarted to enable the Japanese language setting.
This is because the default English and French languages do not have a translation key.
When I open the page in question, the buttons and text fields that should have translation keys are still in English.
Settings > Configuration