Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KO translation 🇰🇷 #12561

Merged
merged 7 commits into from Feb 22, 2022
Merged

Conversation

iicdii
Copy link
Contributor

@iicdii iicdii commented Feb 17, 2022

What does it do?

Update KO translation.

Why is it needed?

  • Improve/Add translations

How to test it?

  • Add 'ko' into your app config
  • Select 한국어 in your preferred language in admin panel

Related issue(s)/PR(s)

X

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #12561 (315f9a2) into master (81934f5) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12561      +/-   ##
==========================================
+ Coverage   47.59%   47.75%   +0.15%     
==========================================
  Files         210      228      +18     
  Lines        8192     8446     +254     
  Branches     1857     1884      +27     
==========================================
+ Hits         3899     4033     +134     
- Misses       3531     3629      +98     
- Partials      762      784      +22     
Flag Coverage Δ
front ?
unit 47.75% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/generators/generators/lib/plops/controller.js 55.55% <0.00%> (ø)
packages/generators/generators/lib/plops/api.js 21.73% <0.00%> (ø)
...ackages/generators/generators/lib/plops/service.js 57.14% <0.00%> (ø)
packages/generators/generators/lib/plopfile.js 100.00% <0.00%> (ø)
...s/generators/lib/plops/prompts/ct-names-prompts.js 23.52% <0.00%> (ø)
...rators/generators/lib/plops/utils/get-file-path.js 62.50% <0.00%> (ø)
packages/generators/generators/lib/index.js 71.42% <0.00%> (ø)
packages/generators/generators/lib/plops/plugin.js 40.00% <0.00%> (ø)
...ators/generators/lib/plops/utils/validate-input.js 20.00% <0.00%> (ø)
...erators/lib/plops/prompts/bootstrap-api-prompts.js 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81934f5...315f9a2. Read the comment docs.

@vincentbpro vincentbpro self-requested a review February 22, 2022 08:27
Copy link
Contributor

@vincentbpro vincentbpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @iicdii!
Thanks for your contribution! Just one small change, the rest looks good to me :)

packages/core/admin/admin/src/translations/ko.json Outdated Show resolved Hide resolved
@vincentbpro vincentbpro added this to the 4.1.1 milestone Feb 22, 2022
Co-authored-by: Vincent <89356961+vincentbpro@users.noreply.github.com>
Copy link
Contributor

@vincentbpro vincentbpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vincentbpro vincentbpro merged commit 7576b81 into strapi:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants