Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Settings nav notifications #12777

Merged
merged 1 commit into from Mar 9, 2022

Conversation

ronronscelestes
Copy link
Contributor

@ronronscelestes ronronscelestes commented Mar 8, 2022

What

Fixed settings nav notifications UI + added test snapshots

#12729

@ronronscelestes ronronscelestes added pr: fix This PR is fixing a bug source: core:admin Source is core/admin package labels Mar 8, 2022
@ronronscelestes ronronscelestes added this to the 4.1.3 milestone Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #12777 (0fb71af) into master (1cb4307) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 0fb71af differs from pull request most recent head 645e445. Consider uploading reports for the commit 645e445 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12777      +/-   ##
==========================================
+ Coverage   47.61%   47.62%   +0.01%     
==========================================
  Files         228      228              
  Lines        8515     8513       -2     
  Branches     1901     1898       -3     
==========================================
  Hits         4054     4054              
+ Misses       3666     3665       -1     
+ Partials      795      794       -1     
Flag Coverage Δ
front ?
unit 47.62% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../content-manager/server/services/entity-manager.js 31.53% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb4307...645e445. Read the comment docs.

Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HichamELBSI HichamELBSI self-assigned this Mar 8, 2022
@derrickmehaffy derrickmehaffy modified the milestones: 4.1.3, 4.1.4 Mar 8, 2022
Copy link
Contributor

@MarionLemaire MarionLemaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome using Getstarted and admin running on Ubuntu : notification is shown about upgrading Strapi version in Settings section (dot icon after Overview).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants