New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix / Settings nav notifications #12777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12777 +/- ##
==========================================
+ Coverage 47.61% 47.62% +0.01%
==========================================
Files 228 228
Lines 8515 8513 -2
Branches 1901 1898 -3
==========================================
Hits 4054 4054
+ Misses 3666 3665 -1
+ Partials 795 794 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome using Getstarted and admin running on Ubuntu : notification is shown about upgrading Strapi version in Settings section (dot icon after Overview).
What
Fixed settings nav notifications UI + added test snapshots
#12729