New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sanitize media #12781
Fix sanitize media #12781
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12781 +/- ##
==========================================
- Coverage 47.63% 47.60% -0.04%
==========================================
Files 228 228
Lines 8515 8525 +10
Branches 1898 1902 +4
==========================================
+ Hits 4056 4058 +2
- Misses 3665 3672 +7
- Partials 794 795 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
072db8e
to
6a9db23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
On a side note, I think we should prefer using internal services instead of a content API call when dealing with fixtures (such as the createFile). Here it's not an issue since we only care about the file ID, but it could have an impact when manipulating regular entities that have middlewares/policies or even specific validations. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does it do?
Fix bug in sanitize function for medias
Why is it needed?
Redacted for security reasons.
How to test it?
DM if you need instruction