Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode/some fixes #12788

Merged
merged 4 commits into from Mar 9, 2022
Merged

Dark mode/some fixes #12788

merged 4 commits into from Mar 9, 2022

Conversation

vincentbpro
Copy link
Contributor

What does it do?

  • Changes a text in Profile->Experience
  • Changes the guided-tour modal overlay color
  • Fixes the wysiwyg component in dark mode

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #12788 (9105ff9) into features/dark-mode (634bbc1) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 9105ff9 differs from pull request most recent head 5196f3f. Consider uploading reports for the commit 5196f3f to get more accurate results

Impacted file tree graph

@@                  Coverage Diff                   @@
##           features/dark-mode   #12788      +/-   ##
======================================================
+ Coverage               47.61%   47.64%   +0.03%     
======================================================
  Files                     228      228              
  Lines                    8515     8473      -42     
  Branches                 1901     1891      -10     
======================================================
- Hits                     4054     4037      -17     
+ Misses                   3666     3648      -18     
+ Partials                  795      788       -7     
Flag Coverage Δ
front ∅ <ø> (∅)
unit 47.64% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/plugins/i18n/server/services/content-types.js 88.75% <0.00%> (-2.07%) ⬇️
packages/core/upload/server/services/upload.js 16.38% <0.00%> (-0.10%) ⬇️
...s/plugins/i18n/server/controllers/content-types.js 100.00% <0.00%> (ø)
packages/core/utils/lib/convert-query-params.js 14.76% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634bbc1...5196f3f. Read the comment docs.

@vincentbpro vincentbpro merged commit da87b7e into features/dark-mode Mar 9, 2022
@vincentbpro vincentbpro deleted the dark-mode/some-fixes branch March 9, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants