Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations cleanup: merge duplicated translations #12841

Conversation

vincentbpro
Copy link
Contributor

What does it do?

It merges duplicated translations under global shared keys
It has been done by running the interactive merge script node scripts/front/merge-duplicated-translations

Merged translations

  "global.see-more": "See more",
  "global.change-password": "Change password",
  "global.password": "Password",
  "global.content-manager": "Content Manager",
  "global.documentation": "Documentation",
  "global.details": "Details",
  "global.roles": "Roles",
  "global.users": "Users",
  "global.profile": "Profile",
  "global.description": "Description",
  "global.name": "Name",
  "global.delete": "Delete",
  "global.actions": "Actions",
  "global.settings": "Settings",
  "global.select-all-entries": "Select all entries",
  "global.select": "Select",
  "global.marketplace": "Marketplace",
  "global.save": "Save",
  "global.back": "Back",
  "global.plugins": "Plugins",
  "global.none": "None",
  "global.type": "Type",
  "global.continue": "Continue",
  "global.finish": "Finish",
  "global.delete-target": "Delete {target}",
  "global.reset-password": "Reset password",
  "global.disabled": "Disabled",
  "global.enabled": "Enabled"

It also reorders translation files

@vincentbpro vincentbpro added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features labels Mar 15, 2022
@vincentbpro vincentbpro added this to the 4.1.4 milestone Mar 15, 2022
@vincentbpro vincentbpro added this to In progress in Product Growth via automation Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #12841 (60d0fb4) into feat/translations-cleanup (3d0c5a9) will decrease coverage by 0.07%.
The diff coverage is 91.30%.

❗ Current head 60d0fb4 differs from pull request most recent head 99f8cff. Consider uploading reports for the commit 99f8cff to get more accurate results

@@                      Coverage Diff                      @@
##           feat/translations-cleanup   #12841      +/-   ##
=============================================================
- Coverage                      47.64%   47.57%   -0.08%     
=============================================================
  Files                            210      229      +19     
  Lines                           8177     8532     +355     
  Branches                        1849     1906      +57     
=============================================================
+ Hits                            3896     4059     +163     
- Misses                          3520     3676     +156     
- Partials                         761      797      +36     
Flag Coverage Δ
front ?
unit 47.57% <91.30%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../content-manager/server/services/entity-manager.js 31.53% <ø> (+0.55%) ⬆️
...ger/server/services/utils/configuration/layouts.js 14.47% <ø> (+4.59%) ⬆️
.github/actions/check-pr-status/index.js 91.30% <91.30%> (ø)
packages/core/upload/server/utils/file.js 23.52% <0.00%> (-6.48%) ⬇️
packages/core/utils/lib/traverse-entity.js 48.33% <0.00%> (-5.67%) ⬇️
packages/providers/upload-local/lib/index.js 23.68% <0.00%> (-4.89%) ⬇️
packages/core/utils/lib/convert-query-params.js 13.45% <0.00%> (-1.94%) ⬇️
packages/core/utils/lib/parse-type.js 80.00% <0.00%> (-1.14%) ⬇️
...pe-builder/server/controllers/validation/common.js 66.66% <0.00%> (-0.84%) ⬇️
packages/core/database/lib/query/helpers/where.js 10.22% <0.00%> (-0.24%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da133ec...99f8cff. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work 👏

Do you plan on migrating the component.Input.error.* translations as well to use the global.error.* instead?

@alexandrebodin alexandrebodin modified the milestones: 4.1.4, 4.1.5 Mar 16, 2022
@vincentbpro
Copy link
Contributor Author

Huge work clap

Do you plan on migrating the component.Input.error.* translations as well to use the global.error.* instead?

Great idea, I'm taking note of that 👍

@vincentbpro vincentbpro merged commit 20c36e7 into feat/translations-cleanup Mar 23, 2022
Product Growth automation moved this from In progress to Fixed/Shipped Mar 23, 2022
@vincentbpro vincentbpro deleted the translations-cleanup/merge-duplicated-translations branch March 23, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
No open projects
Product Growth
Fixed/Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants