New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations cleanup: merge duplicated translations #12841
Translations cleanup: merge duplicated translations #12841
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/translations-cleanup #12841 +/- ##
=============================================================
- Coverage 47.64% 47.57% -0.08%
=============================================================
Files 210 229 +19
Lines 8177 8532 +355
Branches 1849 1906 +57
=============================================================
+ Hits 3896 4059 +163
- Misses 3520 3676 +156
- Partials 761 797 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work 👏
Do you plan on migrating the component.Input.error.*
translations as well to use the global.error.*
instead?
packages/core/content-type-builder/admin/src/components/AllowedTypesSelect/index.js
Outdated
Show resolved
Hide resolved
Great idea, I'm taking note of that 👍 |
What does it do?
It merges duplicated translations under global shared keys
It has been done by running the interactive merge script
node scripts/front/merge-duplicated-translations
Merged translations
It also reorders translation files