Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Upgrade react-redux from 7.2.3 to 7.2.6 #12993

Closed
wants to merge 1 commit into from
Closed

[Snyk] Upgrade react-redux from 7.2.3 to 7.2.6 #12993

wants to merge 1 commit into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to upgrade react-redux from 7.2.3 to 7.2.6.

merge advice
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

  • The recommended version is 3 versions ahead of your current version.
  • The recommended version was released 5 months ago, on 2021-10-25.
Release notes
Package name: react-redux
  • 7.2.6 - 2021-10-25

    Just a quick fix for a Yarn install warning. Sorry about the noise!

    Changes

    • Remove workspaces from our package.json to silence a Yarn warning (@ timdorr)
  • 7.2.5 - 2021-09-04

    This release shrinks the size of our internal Subscription class, and updates useSelector to avoid an unnecessary selector call on mount.

    Changes

    Subscription Size Refactor

    Our internal Subscription implementation has been written as a class ever since it was added in v5. By rewriting it as a closure factory, we were able to shave a few bytes off the final bundle size.

    useSelector Mount Optimization

    A user noticed that useSelector had never been given an early "bail out if the root state is the same" check to match how connect works. This resulted in a usually-unnecessary second call to the provided selector on mount. We've added that check.

    Entry Point Consolidation

    We've consolidated the list of exported public APIs into a single file, and both the index.js and alternate-renderers.js entry points now re-export everything from that file. No meaningful change here, just shuffling lines of code around for consistency.

    Other Updates

    React-Redux v8 and React 18 Development

    With the announcement of React 18, we've been working with the React team to plan our migration path to keep React-Redux fully compatible with React's upcoming features.

    We've already migrated the React-Redux main development branch to TypeScript, and are prototyping compatibility implementation updates. We'd appreciate any assistance from the community in testing out these changes so that we can ensure React-Redux works great for everyone when React 18 is ready!

    Internal Tooling Updates

    Our master branch now uses Yarn v2 for package management, is built with TypeScript, and we've made CI updates to test against multiple TS versions.

    The 7.x branch has also been updated to use Yarn v2 for consistency.

    These only affect contributors to the React-Redux package itself.

    Changelog

    v7.2.4...v7.2.5

  • 7.2.4 - 2021-04-24

    This release drops our dependency on the core redux package by inlining bindActionCreators, and tweaks useSelector to ensure that selectors aren't run an extra time while re-rendering.

    Changelog

    Redux Dependency Removal

    React-Redux has always imported the bindActionCreators utility from the core redux package for use in connect. However, that meant that we had to have a peer dependency on redux, and this was the only reason we actually required that redux be installed. This became more annoying with the arrival of Redux Toolkit, which has its own dependency on redux internally, and thus users typically saw peer dependency warnings saying that "redux isn't listed as a dependency in your app".

    Code reuse across separate packages is a great thing, but sometimes the right thing to do is duplicate code. So, we've inlined bindActionCreators directly into React-Redux, and we've completely dropped the dependency on Redux. This means that React-Redux will no longer produce a peerDep warning when used with Redux Toolkit, and <Provider> and connect really only need a Redux-store-compatible value to work right.

    useSelector Fixes

    Users reported that useSelector was re-running selector functions again unnecessarily while rendering after a dispatch. We've tweaked the logic to ensure that doesn't happen.

    useSelector also now has checks in development to ensure that selector and equalityFn are functions.

    Changes

    v7.2.3...v7.2.4

  • 7.2.3 - 2021-03-23

    This release improves behavior in useSelector by returning the existing reference if the newly returned selector result passes the equality check, and adds a hard dependency on the @ types/react-redux package to ensure TS users always have the typedefs installed.

    Changes

    useSelector Results Reuse

    Issue #1654 reported that useSelector was returning new references from a selector even if the equality comparison function returned true. This is because the equality check was only ever being performed during the action dispatch process.

    We now run the equality comparison against the value calculated by the selector while rendering, and return the existing reference for consistency if the old and new values are considered equal. This should improve some cases where further derived values where being recalculated unnecessarily.

    TS Types Now Included

    React-Redux has always been written in plain JS, and the typedefs maintained by the community in DefinitelyTyped. We plan on eventually rewriting the library in TypeScript in a future React-Redux v8 release, but until then the types can stay in DT.

    However, having to always manually install @ types/react-redux is annoying, and some users have gotten confused by that. This release adds a hard dependency on @ types/react-redux, so that if you install react-redux, you automatically get the types as well. This should simplify the process for TS users.

    Docs Updates

    We've made several docs updates recently:

    • Renamed "Quick Start" to "Getting Started" and "Static Typing" to "Usage with TypeScript"
    • Dropped the docs API versioning setup, as the legacy API version docs pages were rarely viewed and the versioning setup confused docs contributors
    • Moved the old "Intro > Basic Tutorial" to "Tutorials > Connect" and marked it as semi-obsolete

    We are currently working on a new React-Redux tutorial that will teach the React-Redux hooks as the primary approach, based on the "UI and React" page in the Redux docs "Fundamentals" tutorial.

    Changelog

    v7.2.2...v7.2.3

from react-redux GitHub release notes
Commit messages
Package name: react-redux

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@strapi-cla
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited

Codecov Report

Merging #12993 (56f7e08) into master (9afc313) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12993   +/-   ##
=======================================
  Coverage   47.94%   47.94%           
=======================================
  Files         230      230           
  Lines        8593     8593           
  Branches     1919     1919           
=======================================
  Hits         4120     4120           
  Misses       3679     3679           
  Partials      794      794
Flag Coverage Δ
front ?
unit 47.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afc313...56f7e08. Read the comment docs.

@soupette soupette added source: dependencies Source is dependency problem pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 29, 2022
@soupette soupette added this to the 4.1.6 milestone Mar 29, 2022
@soupette soupette closed this Mar 29, 2022
@soupette soupette deleted the snyk-upgrade-7ff56413479a926d828bb4e3cf05e8ba branch March 29, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupette soupette soupette approved these changes

Assignees
No one assigned
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies Source is dependency problem
Projects
None yet
Milestone
4.1.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snyk-bot @strapi-cla @soupette