DynamicTable: Show id for media and relations in components #13005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gu-stav
added
source: core:content-manager
soupette
reviewed
Mar 29, 2022
...core/admin/admin/src/content-manager/components/DynamicTable/CellContent/utils/hasContent.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## releases/4.1.6 #13005 +/- ##
===============================================
Coverage 47.87% 47.87%
===============================================
Files 231 231
Lines 8619 8619
Branches 1926 1926
===============================================
Hits 4126 4126
Misses 3695 3695
Partials 798 798
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
gu-stav
force-pushed
the
fix/list-view-media-relation-id
branch
from
e68f982
to
25db315
Compare
soupette
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Makes sure we display the ID for media and relations in single components in the list view instead of
-Kapture.2022-03-29.at.17.19.48.mp4
Why is it needed?
Consistency.
How to test it?
Create a table with components, which have a main field of type media or relation and see the value being displayed.
Related issue(s)/PR(s)