Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow date fields to be selected as component main fields #13006

Merged
merged 1 commit into from Mar 30, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Mar 29, 2022

What does it do?

Allows fields of type date to be selected as a components main field.

Why is it needed?

Because all other date flavours (time, dateTime) are already selectable.

How to test it?

  1. Create a component that contains a field of type date
  2. Configure the view of the component to use the date field as entry title

Related issue(s)/PR(s)

@gu-stav gu-stav requested a review from soupette March 29, 2022 17:43
@gu-stav gu-stav added source: core:content-manager Source is core/content-manager package pr: fix This PR is fixing a bug labels Mar 29, 2022
@gu-stav gu-stav added this to the 4.1.6 milestone Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #13006 (6d04c64) into master (f05ce9b) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13006      +/-   ##
==========================================
- Coverage   47.94%   47.87%   -0.07%     
==========================================
  Files         230      231       +1     
  Lines        8594     8619      +25     
  Branches     1919     1926       +7     
==========================================
+ Hits         4120     4126       +6     
- Misses       3680     3695      +15     
- Partials      794      798       +4     
Flag Coverage Δ
front ?
unit 47.87% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/database/lib/entity-manager.js 3.81% <0.00%> (-0.02%) ⬇️
packages/core/database/lib/connection.js 24.13% <0.00%> (ø)
packages/core/database/lib/index.js 30.76% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05ce9b...6d04c64. Read the comment docs.

@alexandrebodin alexandrebodin modified the milestones: 4.1.6, 4.2.0 Mar 30, 2022
@gu-stav gu-stav merged commit c83babe into master Mar 30, 2022
@gu-stav gu-stav deleted the fix/components-date-main-field branch March 30, 2022 14:41
@alexandrebodin alexandrebodin modified the milestones: 4.2.0, 4.1.12 May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: Can not select date fields as main field
3 participants