Prevent argv check on "add-missing-keys-to-other-language"
#13113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrickmehaffy
approved these changes
May 19, 2022
derrickmehaffy
added
source: tooling
alexandrebodin
requested review from
vincentbpro
and removed request for
alexandrebodin
alexandrebodin
approved these changes
May 31, 2022
alexandrebodin
changed the title
argv check on "add-missing-keys-to-other-language"argv check on "add-missing-keys-to-other-language"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes a bug that doesn't affect many users but causes unit tests to fail.
There is a
require.main === modulein the file, Next to theargvcheck file,All I did was moving
argvcheck within theifblock to prevent the check when the module is being imported (like in thescripts/front/__tests__/add-missing-keys-to-other-language.test.js)Why is it needed?
The file is not imported anywhere, I'm not sure if anyone imports
updateMissingKeysToJSONfrom this file (which is a script =>scripts/front/add-missing-keys-to-other-language.test.js),Maybe deleting the
module.exportsand therequire.main === modulecheck is a better refactoring solution,I agree with you, "Why is it needed?"
How to test it?
Run
yarn test:unitin the "main" branch and compare the output of the same command within this PR's branch.