Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2022-29256 #13449

Merged
merged 1 commit into from Jun 3, 2022
Merged

Fix CVE-2022-29256 #13449

merged 1 commit into from Jun 3, 2022

Conversation

derrickmehaffy
Copy link
Member

What does it do?

Updates Sharp to latest version

Why is it needed?

CVE Details: GHSA-gp95-ppv5-3jc5

Low sev as it requires your build env to be vuln but it's a quick fix.

How to test it?

Install and run yarn audit check to make sure there is no CVE alert

Related issue(s)/PR(s)

N/A

CVE Details: GHSA-gp95-ppv5-3jc5

Low sev as it requires your build env to be vuln but it's a quick fix.
@derrickmehaffy derrickmehaffy added source: dependencies Source is dependency problem pr: fix This PR is fixing a bug labels Jun 2, 2022
@derrickmehaffy derrickmehaffy added this to the 4.1.13 milestone Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #13449 (2ea34d2) into master (98c8b53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13449   +/-   ##
=======================================
  Coverage   53.65%   53.65%           
=======================================
  Files        1171     1171           
  Lines       30073    30073           
  Branches     5503     5495    -8     
=======================================
  Hits        16136    16136           
  Misses      12123    12123           
  Partials     1814     1814           
Flag Coverage Δ
front 55.91% <ø> (ø)
unit 48.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/admin/admin/src/pages/App/utils/customRoutes.js
...nents/ConditionsModal/ActionRow/utils/constants.js
...admin/src/pages/SettingsPage/utils/customRoutes.js 0.00% <0.00%> (ø)
...ts/ContentTypeCollapse/Collapse/utils/constants.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c8b53...2ea34d2. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 0d8254e into master Jun 3, 2022
@alexandrebodin alexandrebodin deleted the fix/cve-2022-29256 branch June 3, 2022 08:02
@Convly Convly modified the milestones: 4.1.13, 4.2.0 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: dependencies Source is dependency problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants