CTB: Improve UI validation for enum values

[gu-stav]

What does it do?

Builds on top of #13503, to improve the enum values validation in the admin UI. Instead of testing each value directly this PR tests the regressed value. This will allow more values and only fail on the ones that GraphQL can not deal with.

Why is it needed?

It helps to prevent crashing Strapi at the bootstrap phase, after a new invalid value has been added to an enum field in the admin UI.

How to test it?

1. Navigate to CTB
2. Add a new enum field to a content-type
3. Add invalid values (such as --1)
4. Validate a frontend validation error is shown

Related issue(s)/PR(s)

• Refs added regex verification for CTB enum type #13503
• Fixes Enumeration caused Strapi to crash and wipe all data #13428

[codecov]

Codecov Report

Merging #13717 (5be82a4) into master (92558c8) will decrease coverage by 5.61%.
The diff coverage is 0.00%.

❗ Current head 5be82a4 differs from pull request most recent head 87435f5. Consider uploading reports for the commit 87435f5 to get more accurate results

@@            Coverage Diff             @@
##           master   #13717      +/-   ##
==========================================
- Coverage   54.33%   48.72%   -5.62%     
==========================================
  Files        1197      216     -981     
  Lines       30591     8464   -22127     
  Branches     5562     1916    -3646     
==========================================
- Hits        16622     4124   -12498     
+ Misses      12160     3563    -8597     
+ Partials     1809      777    -1032     

Flag	Coverage Δ
front	?
unit	48.72% <0.00%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ontent-manager/server/controllers/content-types.js	29.62% <0.00%> (-1.14%)	⬇️
packages/core/database/lib/migrations/index.js	30.00% <0.00%> (ø)
packages/core/database/lib/query/helpers/where.js	10.22% <0.00%> (ø)
...nents/DynamicTable/CellContent/utils/hasContent.js
...ntent-manager/components/PreviewWysiwyg/Wrapper.js
...t-manager/hooks/useFetchContentTypeLayout/index.js
...dmin/admin/src/translations/languageNativeNames.js
...admin/src/components/FormModal/attributes/types.js
...pe-builder/admin/src/components/FormModal/index.js
...UploadAssetDialog/AddAssetStep/FromComputerForm.js
... and 975 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92558c8...87435f5. Read the comment docs.

[Convly]

Thanks for the change. It looks like we're also operating the doesNotStartWithANumber check in the content-type domain code.
Should we add some consistency between both the front & back validations?

[gu-stav]

@Convly I think it's a good idea! I've added the GraphQL enum check and another for empty values - duplicates are checked already.

I've changed the empty values check from checking the raw values to checking the regressed values, as this is the behavior I want I think.

Does that work for you?

[Convly]

Thanks for the update, I just have some questions

[Convly]

Maybe it's better if we're talking about the enum regexp instead?
I would prefer we avoid coupling/referencing GraphQL to core code

[gu-stav]

I agree, but on the other hand the coupling with GraphQL is the reason why need to this. Therefore I'd prefer to explicit here and to explain why ...

Would it help if I expand on the comment?

[Convly]

Yep might be a good idea to explain a bit more why we're referencing GraphQL here?

[gu-stav]

Added in f880614 Does that work for you, @Convly?

[derrickmehaffy]

Ah the good old chicken 🐓 vs egg 🥚 issue.

[pwizla]

Please let me know when this one is merged so that I can merge documentation PR #984 😊 — if it's still worth it.

[gu-stav]

@pwizla I will. Doing my best to get this one merged, so that we do not have to introduce the disclaimer :)

[petersg83]

LGTM :)

Requested changes have been addressed