Replace remaining moment-js calls with date-fns

[gu-stav]

What does it do?

#13579 made me curious why we do have moment-js next to date-fns in our codebase. Turns out: only because of one call that can easily be replaced by date-fns. This should remove approx. 290kb / 70kb (gzipped) from the frontend bundle and makes it clear that we are using date-fns primarily for handle dates.

Before	After

I think it is safe to remove the check and corresponding test for removeKeyInObject: the function is only called by the EditViewDataManager, which (at least since v4) should not pass around moment-js dates anymore.

Why is it needed?

To keep the dependencies clean (moment-js still needs to be installed as sub-dependency though) and keep the bundle size small.

How to test it?

1. Test creating a new role (using the EE) - the prefilled date in the description should match the current date

[codecov]

Codecov Report

Merging #13728 (7bf5c0d) into master (7dec7f1) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 7bf5c0d differs from pull request most recent head 562c73a. Consider uploading reports for the commit 562c73a to get more accurate results

@@            Coverage Diff             @@
##           master   #13728      +/-   ##
==========================================
- Coverage   54.33%   54.32%   -0.01%     
==========================================
  Files        1197     1197              
  Lines       30596    30594       -2     
  Branches     5563     5562       -1     
==========================================
- Hits        16623    16621       -2     
  Misses      12164    12164              
  Partials     1809     1809              

Flag	Coverage Δ
front	56.70% <ø> (-0.01%)	⬇️
unit	48.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nts/EditViewDataManagerProvider/utils/cleanData.js	94.44% <ø> (ø)
...min/src/content-manager/utils/removeKeyInObject.js	95.23% <ø> (-0.42%)	⬇️
...dmin/admin/src/translations/languageNativeNames.js	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dec7f1...562c73a. Read the comment docs.

[alexandrebodin]

So happy to see moment go :D nice job!

[alexandrebodin]

do we want that change ?

[gu-stav]

I think it is ok, for 2 reasons:

• before the value was mocked

  strapi/packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/EditPage/tests/index.test.js

  Lines 58 to 60 in 377597f

  	moment()
  	.format.mockReturnValueOnce('2021–01–30T12:34:56+00:00')
  	.mockReturnValueOnce('01–30-2021');

  and didn't work properly
• this acts as a comment when you create a new role; the text is added to the description field on a new role, so the format difference doesn't matter that much imo

[alexandrebodin]

LGTM. Works well 👍