Fix count issue when deep filtering #13928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassel17
added
source: core:database
Bassel17
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13928 +/- ##
==========================================
- Coverage 55.35% 55.34% -0.01%
==========================================
Files 1258 1258
Lines 31699 31702 +3
Branches 5734 5735 +1
==========================================
Hits 17546 17546
- Misses 12337 12340 +3
Partials 1816 1816
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bassel17
requested review from
petersg83,
alexandrebodin,
Convly and
innerdvations
innerdvations
previously approved these changes
Aug 2, 2022
alexandrebodin
requested changes
Aug 2, 2022
|
Thank you for pursuing this @Bassel17 and @alexandrebodin ! |
alexandrebodin
requested changes
Aug 3, 2022
alexandrebodin
requested changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Changes the count implementation in the query builder, so it uses
countDistinct()based on the column idWhy is it needed?
When counting with deep filters columns were counted multiple times based on their relation
How to test it?
Create a content type with a relation (one-to-many or many-to-many) (you can take a look at the issue linked below for more details) add multiple elements to the relation field and then try to get the content type while filtering on that field, the total in the meta should be correct.
Related issue(s)/PR(s)
fix #7631