Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Windows tsconfig.json resolution. aka: Typescript Project detection #14088

Closed
wants to merge 2 commits into from
Closed

Fix: Windows tsconfig.json resolution. aka: Typescript Project detection #14088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8d0446
fix: windows tsconfig find fix.
psyirius Aug 12, 2022
d7a755f
Merge branch 'main' into ts-config-path-norm-fix
innerdvations Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/utils/typescript/lib/utils/get-config-path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ module.exports = (dir, { filename = DEFAULT_TS_CONFIG_FILENAME, ancestorsLookup
if (!configFilePath || ancestorsLookup) {
return configFilePath;
psyirius marked this conversation as resolved.
Show resolved Hide resolved
}

const configFileAbsolutePath = path.resolve(configFilePath);
psyirius marked this conversation as resolved.
Show resolved Hide resolved

return configFilePath.startsWith(dirAbsolutePath) ? configFilePath : undefined;
return configFileAbsolutePath.startsWith(dirAbsolutePath) ? configFileAbsolutePath : undefined;
};