Remove duplicated admin api route for batch delete users #14276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
deletes an admin API route from
roles
that already exists inusers
and should only exist there; they're identicalWhy is it needed?
the route shouldn't be there; not safe to have the same route in two places and was probably a mistake
Looking at the history of what happened here, it looks like all the routes were in one file, then role batch delete was removed, and then it was split up into separate files and users batch delete got copied to two places. So it feels like we should update this with a roles batch delete, except that we're not using it anywhere, so there's no reason for it to exist.
How to test it?
Admin API batch delete users call should still work
Related issue(s)/PR(s)