Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated admin api route for batch delete users #14276

Merged
merged 4 commits into from Dec 27, 2022

Conversation

innerdvations
Copy link
Contributor

@innerdvations innerdvations commented Aug 31, 2022

What does it do?

deletes an admin API route from roles that already exists in users and should only exist there; they're identical

Why is it needed?

the route shouldn't be there; not safe to have the same route in two places and was probably a mistake

Looking at the history of what happened here, it looks like all the routes were in one file, then role batch delete was removed, and then it was split up into separate files and users batch delete got copied to two places. So it feels like we should update this with a roles batch delete, except that we're not using it anywhere, so there's no reason for it to exist.

How to test it?

Admin API batch delete users call should still work

Related issue(s)/PR(s)

@innerdvations innerdvations added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package labels Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 60.49% // Head: 60.49% // No change to project coverage 👍

Coverage data is based on head (43c6874) compared to base (b76c413).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14276   +/-   ##
=======================================
  Coverage   60.49%   60.49%           
=======================================
  Files        1352     1352           
  Lines       33174    33174           
  Branches     6337     6337           
=======================================
  Hits        20070    20070           
  Misses      11271    11271           
  Partials     1833     1833           
Flag Coverage Δ
back 50.35% <ø> (ø)
front 65.05% <ø> (ø)
unit_back 50.35% <ø> (ø)
unit_front 65.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@innerdvations innerdvations merged commit 44c3c09 into main Dec 27, 2022
@innerdvations innerdvations deleted the fix/delete-duplicate-route-users-delete branch December 27, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants