Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discord link on admin panel homepage #14513

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

DanieleAurilio
Copy link
Contributor

What does it do?

Changed discord link redirect on admin panel homepage.

Why is it needed?

The Discord icon on admin panel homepage redirected you to Slack.

How to test it?

Go to Admin Panel Homepage and click on Discord icon:

image

Related issue(s)/PR(s)

#14330

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 58.71% // Head: 58.71% // No change to project coverage 👍

Coverage data is based on head (b8cea20) compared to base (d4e1b4a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14513   +/-   ##
=======================================
  Coverage   58.71%   58.71%           
=======================================
  Files        1321     1321           
  Lines       31976    31976           
  Branches     5954     5954           
=======================================
  Hits        18775    18775           
  Misses      11341    11341           
  Partials     1860     1860           
Flag Coverage Δ
front 62.41% <ø> (ø)
unit 50.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/admin/admin/src/pages/HomePage/SocialLinks.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@derrickmehaffy derrickmehaffy added pr: fix This PR is fixing a bug source: core:admin Source is core/admin package labels Oct 1, 2022
derrickmehaffy
derrickmehaffy previously approved these changes Oct 1, 2022
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @DanieleAurilio good catch 😃
you will need to update the failing snapshots by using yarn test:front -u command at the root of strapi 👀

@ronronscelestes ronronscelestes added this to the 4.4.4 milestone Oct 10, 2022
Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @DanieleAurilio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants