Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unknown Dialect Windows issue #14521

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

kulak91
Copy link
Contributor

@kulak91 kulak91 commented Oct 2, 2022

What does it do?

Resolves path on Windows OS If tsconfig file is provided.
It doesn't affect strapi if tsconfig is not provided, but if it does it changes the path with correct backslashes

Why is it needed?

People with Windows machines also want to use strapi ts.

How to test it?

Before : C:/Users/currentUser/project/server/tsconfig.json
After: C:\Users\currentUser\project\server\tsconfig.json

Related issue(s)/PR(s)

issue link

@petersg83 petersg83 added pr: fix This PR is fixing a bug source: core:utils Source is core/utils or utils packages labels Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 58.70% // Head: 58.70% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (89d8ac9) compared to base (02af046).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 89d8ac9 differs from pull request most recent head cde32fc. Consider uploading reports for the commit cde32fc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14521   +/-   ##
=======================================
  Coverage   58.70%   58.70%           
=======================================
  Files        1321     1321           
  Lines       31977    31978    +1     
  Branches     5952     5953    +1     
=======================================
+ Hits        18771    18772    +1     
  Misses      11346    11346           
  Partials     1860     1860           
Flag Coverage Δ
front 62.39% <ø> (ø)
unit 50.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/utils/typescript/lib/utils/get-config-path.js 90.00% <100.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@dalabarge
Copy link

For those still experiencing the problem is bad Dockerization. The problem is the missing tsconfig.json from the Docker container. You can copy it using:

COPY ./tsconfig.json ./

Just under your WORKDIR line where you also copy package.json. Once the file is there then the connections can be parsed and you can move on to the next error in your start up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:utils Source is core/utils or utils packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.2 beta] - Error: Unknown dialect undefined on strapi app when start develop
5 participants