Updating koa/cors to 3.4.2 in order to fix cors filter origin problem #14357

[CleberRossi]

Updating koa/cors to 3.4.2 in order to fix cors filter origin problem #14357

There was a bug that is fixed on koa/cors 3.4.2 version.

Fixes #14357

What does it do?

In order to fix #14357 I had to fix another bug on koa/cors, as my PR was merged -> koajs/cors#87 I'm creating this PR in order to update the lib

Why is it needed?

Koa/cors was not calling origin middleware when the origin header was not present. Hence, even when you set credentials as false, the middleware was not called and people could not get Access-Control-Allow-Origin as '*'.

How to test it?

Set credentials as false on config/middlewares.js, call any API in order to retrive Access-Control-Allow-Origin as '*' as DEFAULT.

{
    name: 'strapi::cors',
    config: {
      credentials: false,
    },
  },

Related issue(s)/PR(s)

Fix #14357

Please, could you add https://hacktoberfest.com/ label?

[CleberRossi]

@Convly @derrickmehaffy If you guys could help, please ? :) Letting you know because this fix a severity: medium issue. #14357

[codecov]

Codecov Report

Base: 58.71% // Head: 58.71% // No change to project coverage 👍

Coverage data is based on head (89813f8) compared to base (3ddf162).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14552   +/-   ##
=======================================
  Coverage   58.71%   58.71%           
=======================================
  Files        1321     1321           
  Lines       31976    31976           
  Branches     5954     5954           
=======================================
  Hits        18775    18775           
  Misses      11341    11341           
  Partials     1860     1860           

Flag	Coverage Δ
front	62.41% <ø> (ø)
unit	50.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Convly]

Tested and works fine. Thanks for the contribution 🎉

[strapi-bot]

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/cors-changed-in-4-22-0-my-cors-settings-no-longer-work-but-origin-does/37240/3