Fixing #14587: Can edit json field with false value #14588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Convly
added
source: core:content-manager
Codecov ReportBase: 59.62% // Head: 59.62% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #14588 +/- ##
=======================================
Coverage 59.62% 59.62%
=======================================
Files 1339 1339
Lines 32566 32566
Branches 6207 6207
=======================================
Hits 19418 19418
Misses 11289 11289
Partials 1859 1859
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
joshuaellis
approved these changes
Nov 17, 2022
|
Thanks for the contribution! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR is fixing #14587. the
formatContentTypeDatafunction has a issue when format a json data which value isfalse.