New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-provider): add https protocol when missing in file url #14654
Conversation
Codecov ReportBase: 58.75% // Head: 58.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #14654 +/- ##
=======================================
Coverage 58.75% 58.75%
=======================================
Files 1322 1323 +1
Lines 32026 32041 +15
Branches 5968 5970 +2
=======================================
+ Hits 18816 18826 +10
- Misses 11349 11353 +4
- Partials 1861 1862 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Adding hard coded https:// to url because Digital Ocean only gives the uri without protocol in response to the upload. Fix #14288
fde88d2
to
0c9a4b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
What does it do?
Adding https:// to url that doesn't have any.
Also adding unit tests to this provider.
Why is it needed?
Digital Ocean only gives the URI without protocol in response to the upload.
How to test it?
The steps to reproduce are defined in the issue #14288
Steps to reproduce the behavior
Related issue(s)/PR(s)
Fix #14288