Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove design-system from helper deps #14679

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

joshuaellis
Copy link
Member

What does it do?

  • removes @strapi/design-system from the helper plugin deps

Why is it needed?

  • Because I accidentally introduced it in e84eb50 when I should have updated the devDeps

@joshuaellis joshuaellis added source: core:helper-plugin Source is core/helper-plugin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 58.76% // Head: 58.76% // No change to project coverage 👍

Coverage data is based on head (ab535e8) compared to base (2a4d0ca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14679   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files        1322     1322           
  Lines       32042    32042           
  Branches     5987     5987           
=======================================
  Hits        18829    18829           
  Misses      11351    11351           
  Partials     1862     1862           
Flag Coverage Δ
front 62.47% <ø> (ø)
unit 50.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

yarn.lock Show resolved Hide resolved
@joshuaellis joshuaellis added this to the 4.4.6 milestone Oct 21, 2022
@joshuaellis joshuaellis merged commit 8a72fcd into main Oct 21, 2022
@joshuaellis joshuaellis deleted the chore/fix/remove-dep-from-helper-plugin branch October 21, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:helper-plugin Source is core/helper-plugin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants