-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace directory to be able to get license.txt using a typescript project #14691
Conversation
Codecov ReportBase: 58.76% // Head: 50.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #14691 +/- ##
==========================================
- Coverage 58.76% 50.33% -8.44%
==========================================
Files 1322 281 -1041
Lines 32040 9739 -22301
Branches 5981 2132 -3849
==========================================
- Hits 18829 4902 -13927
+ Misses 11350 3987 -7363
+ Partials 1861 850 -1011
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f887ae4
to
aff2ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What does it do?
It fixes the problem of reading the license.txt file in the EE edition using Typescript.
Why is it needed?
Because before this fix, using the license in the license.txt file was not possible
How to test it?
At the moment there isn't any tests on this.
Related issue(s)/PR(s)
#14328