Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace directory to be able to get license.txt using a typescript project #14691

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

christiancp100
Copy link
Contributor

What does it do?

It fixes the problem of reading the license.txt file in the EE edition using Typescript.

Why is it needed?

Because before this fix, using the license in the license.txt file was not possible

How to test it?

At the moment there isn't any tests on this.

Related issue(s)/PR(s)

#14328

@christiancp100 christiancp100 added pr: fix This PR is fixing a bug source: typescript Source is related to TypeScript (typings, tooling, ...) labels Oct 20, 2022
@christiancp100 christiancp100 self-assigned this Oct 20, 2022
@strapi-cla
Copy link

strapi-cla commented Oct 20, 2022

CLA assistant check
All committers have signed the CLA.

@Convly Convly added source: core:strapi Source is core/strapi package and removed source: typescript Source is related to TypeScript (typings, tooling, ...) labels Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 58.76% // Head: 50.33% // Decreases project coverage by -8.43% ⚠️

Coverage data is based on head (123d871) compared to base (65feb97).
Patch coverage: 90.90% of modified lines in pull request are covered.

❗ Current head 123d871 differs from pull request most recent head aff2ed2. Consider uploading reports for the commit aff2ed2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14691      +/-   ##
==========================================
- Coverage   58.76%   50.33%   -8.44%     
==========================================
  Files        1322      281    -1041     
  Lines       32040     9739   -22301     
  Branches     5981     2132    -3849     
==========================================
- Hits        18829     4902   -13927     
+ Misses      11350     3987    -7363     
+ Partials     1861      850    -1011     
Flag Coverage Δ
front ?
unit 50.33% <90.90%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/core/database/lib/query/helpers/populate.js 2.95% <0.00%> (-0.03%) ⬇️
...es/core/admin/utils/create-plugins-exclude-path.js 100.00% <100.00%> (ø)
packages/providers/upload-aws-s3/lib/index.js 66.66% <100.00%> (ø)
...r/components/DynamicTable/CellContent/CellValue.js
packages/core/admin/admin/src/index.js
...EditView/components/FormApiTokenContainer/index.js
...es/ApiTokens/EditView/components/FormBody/index.js
...es/ApiTokens/EditView/components/FormHead/index.js
.../ApiTokens/EditView/components/Regenerate/index.js
...ges/SettingsPage/pages/ApiTokens/EditView/index.js
... and 1037 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Convly
Convly previously approved these changes Oct 20, 2022
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Convly Convly added this to the 4.4.6 milestone Oct 20, 2022
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@christiancp100 christiancp100 merged commit e2f9ea1 into main Oct 25, 2022
@Convly Convly deleted the fix/ts-does-not-read-license-txt branch October 27, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants