Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default app keys to the server config #14692

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

christiancp100
Copy link
Contributor

What does it do?

Add default APP_KEYS to the kitchensink-ts project

Why is it needed?

Before it was not possible to launch the kitchensink-ts project without providing the APP_KEYS through a .env file.

How to test it?

Launch the kitchensink-ts project and see that it works without providing APP_KEYS through a .env file.

Related issue(s)/PR(s)

@christiancp100 christiancp100 added the pr: fix This PR is fixing a bug label Oct 20, 2022
@christiancp100 christiancp100 self-assigned this Oct 20, 2022
@strapi-cla
Copy link

strapi-cla commented Oct 20, 2022

CLA assistant check
All committers have signed the CLA.

Convly
Convly previously approved these changes Oct 20, 2022
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christiancp100 christiancp100 added the source: tooling Source is GitHub tooling/tests/ect label Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 58.79% // Head: 50.33% // Decreases project coverage by -8.45% ⚠️

Coverage data is based on head (37de813) compared to base (a950015).
Patch has no changes to coverable lines.

❗ Current head 37de813 differs from pull request most recent head 3bdaa4a. Consider uploading reports for the commit 3bdaa4a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14692      +/-   ##
==========================================
- Coverage   58.79%   50.33%   -8.46%     
==========================================
  Files        1324      281    -1043     
  Lines       32092     9739   -22353     
  Branches     6003     2132    -3871     
==========================================
- Hits        18867     4902   -13965     
+ Misses      11360     3987    -7373     
+ Partials     1865      850    -1015     
Flag Coverage Δ
front ?
unit 50.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/components/LogoModalStepper/PendingLogoDialog.js
...ins/i18n/admin/src/components/ModalCreate/index.js
...min/admin/src/components/RBACProvider/constants.js
...ages/SettingsPage/pages/Webhooks/EditView/index.js
...s/admin/src/pages/Roles/CreatePage/tests/server.js
...s/EditPage/components/utils/createArrayOfValues.js
...src/content-manager/components/PlusButton/index.js
...min/src/hooks/useFetchPermissionsLayout/reducer.js
...EditView/components/FormApiTokenContainer/index.js
...MediaLibraryInput/Carousel/CarouselAssetActions.js
... and 1033 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Convly Convly added this to the 4.4.6 milestone Oct 20, 2022
@christiancp100 christiancp100 merged commit 1654b71 into main Oct 25, 2022
@nathan-pichon nathan-pichon deleted the fix/kitchensink-ts-not-default-app-keys branch February 23, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants