Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: Extend theme extension tests and swallow deprecation message #14708

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Oct 24, 2022

What does it do?

With #14001 it is possible to customize both (light and dark) themes. This PR adds tests for that and fixes a deprecation warning.

Why is it needed?

Currently, the tests print the deprecation warning.

Screenshot 2022-10-24 at 09 19 49

How to test it?

Trust in jest.

@gu-stav gu-stav added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Oct 24, 2022
@gu-stav gu-stav added this to the 4.4.6 milestone Oct 24, 2022
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅🏼

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 58.76% // Head: 58.76% // No change to project coverage 👍

Coverage data is based on head (223aac9) compared to base (1ffabc2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14708   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files        1322     1322           
  Lines       32045    32045           
  Branches     5989     5989           
=======================================
  Hits        18831    18831           
  Misses      11351    11351           
  Partials     1863     1863           
Flag Coverage Δ
front 62.47% <ø> (ø)
unit 50.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gu-stav gu-stav merged commit 6f72541 into main Oct 24, 2022
@gu-stav gu-stav deleted the chore/theme-tests branch October 24, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants