Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix prop-type errors in setting list views #14710

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Oct 24, 2022

What does it do?

This fixes the ✨ last two remaining prop-type errors ✨ which the frontend tests are throwing.

Why is it needed?

We are down to zero errors and want to introduce stricter prop-type checking.

How to test it?

In automated tests we trust.

@gu-stav gu-stav added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Oct 24, 2022
@gu-stav gu-stav added this to the 4.4.6 milestone Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 58.76% // Head: 58.76% // No change to project coverage 👍

Coverage data is based on head (697a905) compared to base (1ffabc2).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 697a905 differs from pull request most recent head 756c4bc. Consider uploading reports for the commit 756c4bc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14710   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files        1322     1322           
  Lines       32045    32045           
  Branches     5989     5989           
=======================================
  Hits        18831    18831           
  Misses      11351    11351           
  Partials     1863     1863           
Flag Coverage Δ
front 62.47% <100.00%> (ø)
unit 50.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/pages/SettingsPage/pages/Roles/ListPage/index.js 88.67% <ø> (ø)
...e/pages/Roles/ListPage/components/RoleRow/index.js 94.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gu-stav gu-stav merged commit f033c8f into main Oct 24, 2022
@gu-stav gu-stav deleted the chore/fix-prop-types branch October 24, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants