Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] Exp-320 Change wording in marketplace card #14714

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

madhurisandbhor
Copy link
Contributor

@madhurisandbhor madhurisandbhor commented Oct 24, 2022

What does it do?

Changed marketplace card “Learn more” button text to “More”.

Why is it needed?

When the main navigation is extended in Strapi, the button text in English version is on a double line which is not really aesthetic. This won’t solve the issue for every language, but will solve the issue in the default language of the admin: English. Reference

How to test it?

Go to Marketplace > plugins/providers tab

@madhurisandbhor madhurisandbhor marked this pull request as ready for review October 24, 2022 15:33
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 58.79% // Head: 58.79% // No change to project coverage 👍

Coverage data is based on head (43e0346) compared to base (a950015).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14714   +/-   ##
=======================================
  Coverage   58.79%   58.79%           
=======================================
  Files        1324     1324           
  Lines       32092    32092           
  Branches     6003     6003           
=======================================
  Hits        18867    18867           
  Misses      11360    11360           
  Partials     1865     1865           
Flag Coverage Δ
front 62.47% <ø> (ø)
unit 50.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...MarketplacePage/components/NpmPackageCard/index.js 94.59% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. ✨ To make all actions pass, don't forget to add at least one "source: " and "pr: " label + a milestone before merging it.

@madhurisandbhor madhurisandbhor added pr: fix This PR is fixing a bug source: marketplace Source is admin in-app marketplace labels Oct 26, 2022
@madhurisandbhor madhurisandbhor added this to the 4.4.6 milestone Oct 26, 2022
@madhurisandbhor madhurisandbhor merged commit 97e6bb4 into main Oct 26, 2022
@madhurisandbhor madhurisandbhor deleted the fix/marketplace-card branch October 26, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: marketplace Source is admin in-app marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants