Fix: Make favicon middleware backwards compatible with pngs

[gu-stav]

What does it do?

Makes the switch to png favicons in #14655 backward compatible. In case the .png doesn't exist in the app it falls back to use the .ico version.

Why is it needed?

Ensures backward compatibility.

How to test it?

1. Rename the favicon.png to favicon.ico from the getstarted example
2. Restart the server
3. Validate it does not crash or log an error.

Related issue(s)/PR(s)

• Fixes Error: ENOENT: no such file or directory, open '/workspace/favicon.png' #14693

[codecov]

Codecov Report

Base: 58.79% // Head: 58.79% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1eaea7a) compared to base (527b785).
Patch coverage: 32.00% of modified lines in pull request are covered.

❗ Current head 1eaea7a differs from pull request most recent head b6ee5a9. Consider uploading reports for the commit b6ee5a9 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14736      +/-   ##
==========================================
- Coverage   58.79%   58.79%   -0.01%     
==========================================
  Files        1324     1327       +3     
  Lines       32091    32114      +23     
  Branches     5999     6007       +8     
==========================================
+ Hits        18869    18881      +12     
- Misses      11361    11371      +10     
- Partials     1861     1862       +1     

Flag	Coverage Δ
front	62.46% <9.09%> (-0.02%)	⬇️
unit	50.38% <50.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...lder/admin/src/components/FormModal/forms/index.js	28.18% <0.00%> (ø)
packages/core/database/lib/metadata/index.js	17.54% <0.00%> (-2.46%)	⬇️
packages/core/utils/lib/import-default.js	100.00% <ø> (ø)
...s/FormModal/contentType/createContentTypeSchema.js	14.89% <11.11%> (-1.39%)	⬇️
...ges/core/utils/lib/__tests__/import-default/cjs.js	100.00% <100.00%> (ø)
...ges/core/utils/lib/__tests__/import-default/esm.js	100.00% <100.00%> (ø)
packages/core/utils/lib/index.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[derrickmehaffy]

LGTM

[jhoward1994]

Works well for me 👍