Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM: Replace custom State and Badge components with Status #14761

Merged
merged 3 commits into from Nov 4, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Nov 2, 2022

What does it do?

  • Replaces the custom State component in the CM list view with a default component Status from the design-system.
Before After
Screenshot 2022-11-03 at 15 36 58 Screenshot 2022-11-03 at 15 36 46
  • Replaces Badge with Status in RelationItem
Before After
Screenshot 2022-11-03 at 15 37 32 Screenshot 2022-11-03 at 15 37 59

Why is it needed?

To keep the styling consistent across the app.

Todo

Related issue(s)/PR(s)

@gu-stav gu-stav added source: core:content-manager Source is core/content-manager package pr: fix This PR is fixing a bug labels Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 58.72% // Head: 63.20% // Increases project coverage by +4.47% 🎉

Coverage data is based on head (2d122ec) compared to base (c85bf22).
Patch coverage: 58.33% of modified lines in pull request are covered.

❗ Current head 2d122ec differs from pull request most recent head 55227eb. Consider uploading reports for the commit 55227eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14761      +/-   ##
==========================================
+ Coverage   58.72%   63.20%   +4.47%     
==========================================
  Files        1340     1050     -290     
  Lines       32500    22363   -10137     
  Branches     6143     3909    -2234     
==========================================
- Hits        19086    14134    -4952     
+ Misses      11525     7256    -4269     
+ Partials     1889      973     -916     
Flag Coverage Δ
front 63.20% <58.33%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/content-manager/components/DynamicTable/index.js 43.18% <44.44%> (-0.41%) ⬇️
...-manager/components/RelationInput/RelationInput.js 80.67% <100.00%> (ø)
packages/core/admin/server/controllers/admin.js
...e/permissions/lib/engine/abilities/casl-ability.js
packages/core/upload/server/register.js
packages/core/database/lib/schema/storage.js
...n/ee/server/services/passport/provider-registry.js
packages/utils/typescript/lib/generators/index.js
packages/core/admin/server/services/api-token.js
packages/core/database/lib/types/index.js
... and 281 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gu-stav gu-stav changed the title CM: Replace custom State component with the DS Status component CM: Replace custom State and Badge components with Status Nov 3, 2022
@gu-stav gu-stav marked this pull request as ready for review November 3, 2022 14:39
@gu-stav gu-stav marked this pull request as draft November 3, 2022 14:42
@gu-stav gu-stav added this to the 4.5.0 milestone Nov 3, 2022
@gu-stav gu-stav marked this pull request as ready for review November 3, 2022 15:38
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves a Jira ticket right?

@gu-stav
Copy link
Contributor Author

gu-stav commented Nov 3, 2022

@joshuaellis https://strapi-inc.atlassian.net/browse/CONTENT-651 and implements some prep work for D&P v2 too, which isn't part of a ticket yet. What's better than creating a ticket? Making sure we never have to create one :p

@joshuaellis
Copy link
Member

pre-cognative tickets

Copy link

@maevalienard maevalienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me really happy 😂 Looks good to me, thank you very much!

@gu-stav gu-stav merged commit 7dfd8c5 into main Nov 4, 2022
@gu-stav gu-stav deleted the enhance/cm-list-view-status branch November 4, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants