New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CM: Replace custom State and Badge components with Status #14761
Conversation
Codecov ReportBase: 58.72% // Head: 63.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #14761 +/- ##
==========================================
+ Coverage 58.72% 63.20% +4.47%
==========================================
Files 1340 1050 -290
Lines 32500 22363 -10137
Branches 6143 3909 -2234
==========================================
- Hits 19086 14134 -4952
+ Misses 11525 7256 -4269
+ Partials 1889 973 -916
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
06460dd
to
26ee62f
Compare
6fd2017
to
55227eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This resolves a Jira ticket right?
@joshuaellis https://strapi-inc.atlassian.net/browse/CONTENT-651 and implements some prep work for D&P v2 too, which isn't part of a ticket yet. What's better than creating a ticket? Making sure we never have to create one :p |
pre-cognative tickets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me really happy 😂 Looks good to me, thank you very much!
What does it do?
State
component in the CM list view with a default componentStatus
from the design-system.Badge
withStatus
inRelationItem
Why is it needed?
To keep the styling consistent across the app.
Todo
Related issue(s)/PR(s)