Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation on user update #14822

Merged
merged 1 commit into from Nov 10, 2022
Merged

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Nov 9, 2022

What does it do?

Fix edit problem on users & permission introduced in 4.5.0

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin added source: plugin:users-permissions Source is plugin/users-permissions package pr: fix This PR is fixing a bug labels Nov 9, 2022
@alexandrebodin alexandrebodin added this to the 4.5.1 milestone Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 58.99% // Head: 58.99% // No change to project coverage 👍

Coverage data is based on head (3ef2eab) compared to base (33debd5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14822   +/-   ##
=======================================
  Coverage   58.99%   58.99%           
=======================================
  Files        1349     1349           
  Lines       32697    32697           
  Branches     6181     6181           
=======================================
  Hits        19290    19290           
  Misses      11521    11521           
  Partials     1886     1886           
Flag Coverage Δ
front 63.55% <ø> (ø)
unit 48.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Marc-Roig Marc-Roig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexandrebodin alexandrebodin merged commit a8f807d into main Nov 10, 2022
@alexandrebodin alexandrebodin deleted the fix/users-permissions-user-update branch November 10, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants