Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests relation-list.test.api.js & relations.test.api.js #14823

Merged
merged 1 commit into from Nov 10, 2022

Conversation

petersg83
Copy link
Contributor

What does it do?

Remove test files that were deleted and came back after a bad merge.

  • packages/core/content-manager/server/tests/content-manager/relations.test.api.js was originally deleted there
  • packages/core/content-manager/server/tests/relation-list.test.api.js was originally deleted there

Why is it needed?

Those tests are not relevant anymore

How to test it?

Check green marks

@petersg83 petersg83 added source: core:content-manager Source is core/content-manager package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 9, 2022
@petersg83 petersg83 added this to the 4.5.1 milestone Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 58.99% // Head: 63.55% // Increases project coverage by +4.56% 🎉

Coverage data is based on head (a6015a8) compared to base (33debd5).
Patch has no changes to coverable lines.

❗ Current head a6015a8 differs from pull request most recent head 13cbc31. Consider uploading reports for the commit 13cbc31 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14823      +/-   ##
==========================================
+ Coverage   58.99%   63.55%   +4.56%     
==========================================
  Files        1349     1060     -289     
  Lines       32697    22570   -10127     
  Branches     6181     3947    -2234     
==========================================
- Hits        19290    14345    -4945     
+ Misses      11521     7254    -4267     
+ Partials     1886      971     -915     
Flag Coverage Δ
front 63.55% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/services/permission/sections-builder/builder.js
...r/services/permission/permissions-manager/index.js
packages/core/utils/lib/policy.js
packages/core/database/lib/utils/content-types.js
.../database/lib/lifecycles/subscribers/timestamps.js
...ackages/core/admin/server/validation/permission.js
packages/core/utils/lib/sanitize/visitors/index.js
.../strapi/lib/core-api/controller/collection-type.js
packages/core/database/lib/query/helpers/search.js
...s/i18n/server/services/entity-service-decorator.js
... and 279 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gu-stav gu-stav merged commit 29038e2 into main Nov 10, 2022
@gu-stav gu-stav deleted the fix/api-tests-living-dead branch November 10, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants