Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking system, accessing the CTB #14875

Merged
merged 16 commits into from Nov 22, 2022
Merged

Tracking system, accessing the CTB #14875

merged 16 commits into from Nov 22, 2022

Conversation

simotae14
Copy link
Contributor

@simotae14 simotae14 commented Nov 15, 2022

What does it do?

Added the event didNavigate with the From and to properties when we click in a menu link inside the LeftMenu

Why is it needed?

As a Strapi PM, I want the access to the CTB to be tracked through the event didGoToCTB, so that analytics can be created on the funnel starting from the moment in which a user accesses the CTB.

How to test it?

As a Strapi PM

  • when I access the content type builder section from the side menu
    • then I want the didGoToCTB to be fired
  • when I create a graph on Amplitude
    • then I want the didGoToCTB to be available and working

@simotae14 simotae14 added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features labels Nov 15, 2022
@simotae14 simotae14 self-assigned this Nov 15, 2022
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any known reason you've had to update all the snapshots? 🤔

packages/core/admin/admin/src/components/LeftMenu/index.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 59.58% // Head: 59.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (9514c5f) compared to base (efecf4b).
Patch coverage: 22.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14875      +/-   ##
==========================================
- Coverage   59.58%   59.57%   -0.02%     
==========================================
  Files        1339     1339              
  Lines       32598    32605       +7     
  Branches     6214     6215       +1     
==========================================
  Hits        19424    19424              
- Misses      11311    11317       +6     
- Partials     1863     1864       +1     
Flag Coverage Δ
back 49.70% <ø> (ø)
front 64.07% <22.22%> (-0.03%) ⬇️
unit_back 49.70% <ø> (ø)
unit_front 64.07% <22.22%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...EditView/components/FormApiTokenContainer/index.js 59.37% <ø> (ø)
...es/ApiTokens/EditView/components/FormBody/index.js 100.00% <ø> (ø)
...es/ApiTokens/EditView/components/FormHead/index.js 87.50% <ø> (ø)
.../core/admin/admin/src/components/LeftMenu/index.js 26.47% <22.22%> (-3.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

joshuaellis
joshuaellis previously approved these changes Nov 17, 2022
gu-stav
gu-stav previously approved these changes Nov 17, 2022
joshuaellis
joshuaellis previously approved these changes Nov 17, 2022
@simotae14 simotae14 added this to the 4.5.2 milestone Nov 18, 2022
Copy link
Contributor

@maccomaccomaccomacco maccomaccomaccomacco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's fine

@simotae14 simotae14 merged commit 9f72322 into main Nov 22, 2022
@simotae14 simotae14 deleted the chore/tracking-access-CTB branch November 22, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants